-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for some solver behaviour known issues #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhirschfeld - I think you might want to see this script, given your message at Quansight-Labs/czi-conda-forge-mgmt#5 (comment)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, especially the correct handling of the patches 🚀
One minor quibble would be that the timestamp in question is the build time (IIUC) and not the time that the package was uploaded to the package registry (i.e. not the time that it was available for users to download/install). Though, with automated build infrastructure the build time is probably a close-enough proxy for the uploaded_timestamp
.
The only other observation is that this is an enormous amount of effort (development/CPU) to go to to support something as simple as
select *
from packages
where
package_name = ?
and upload_timestamp < ?
...if the package information was stored in a database rather than a JSON blob.
i.e. I think the JSON blob format is much more complex and must be much less performant than storing the information in a proper database.
That's just my intuition, and might well be wrong, but is why I was interested in the other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing sleuthing!
Description
Checklist - did you ...
news
directory (using the template) for the next release's release notes?cpuonly
#131