Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for some solver behaviour known issues #197

Merged
merged 8 commits into from
May 11, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented May 2, 2023

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 2, 2023
@jaimergp jaimergp mentioned this pull request May 4, 2023
3 tasks
@jaimergp jaimergp marked this pull request as ready for review May 4, 2023 12:17
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhirschfeld - I think you might want to see this script, given your message at Quansight-Labs/czi-conda-forge-mgmt#5 (comment)!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, especially the correct handling of the patches 🚀

One minor quibble would be that the timestamp in question is the build time (IIUC) and not the time that the package was uploaded to the package registry (i.e. not the time that it was available for users to download/install). Though, with automated build infrastructure the build time is probably a close-enough proxy for the uploaded_timestamp.

The only other observation is that this is an enormous amount of effort (development/CPU) to go to to support something as simple as

select *
from packages 
where
    package_name = ?
    and upload_timestamp < ?

...if the package information was stored in a database rather than a JSON blob.

i.e. I think the JSON blob format is much more complex and must be much less performant than storing the information in a proper database.

That's just my intuition, and might well be wrong, but is why I was interested in the other PR.

@jaimergp jaimergp requested review from jezdez and costrouc May 8, 2023 08:13
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing sleuthing!

.pre-commit-config.yaml Show resolved Hide resolved
@jaimergp jaimergp merged commit 3f9d182 into main May 11, 2023
@jaimergp jaimergp deleted the solver-difference-tests branch May 11, 2023 10:39
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
4 participants